Mastodon Feed: Post

Mastodon Feed

Boosted by jwz:
zekjur@mas.to ("Michael Stapelberg 🐧🐹😺") wrote:

PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?

Like https://github.com/i3/i3/pull/6564 for example

Such diffs will be applied by patch(1) (also git-am(1)) as part of the code change!

This is how a sleep(1) made it into i3 4.25-2 in Debian unstable.

GitHub PR i3#6564, where Orestis explains how he tested the patch.
GitHub .patch file for this PR
Debian issue with unexpected delay — the sleep(1) call made it into the code!
test with git-am(1)